-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Issue number 197 add v2 api favorite mixes #207
feat: Issue number 197 add v2 api favorite mixes #207
Conversation
@jozefKruszynski Thanks for the PR. Can this be moved from draft or is more work needed on it? |
I left it as a draft, as I was hoping for some feedback on the code. |
I'll fix the conflict later this evening, as I'm at work at the moment |
@jozefKruszynski Looks like the typing additions I just merged resulted in new conflicts. Sorry! |
Having a hard time getting my changes to work as they did previously. I think I'm losing my mind |
Realised I had completely overcomplicated the whole thing. I have pushed a much simplified version |
Co-authored-by: Johannes L <[email protected]>
A sidenote, after looking more into the tidal2 plugin for KODI, I noticed that there are a few endpoints that use the V2 API
|
Works as expected and tests pass. Merged! |
I guess a robust V2 solution is not what I have produced at all. We can look into a proper implementation in the near future I hope. |
I ended up having to create a MixV2 class as the structure is different enough to warrant it, however, this structure is only used for this one v2 api endpoint, and tidal themselves in their web app use the v1 api for every other call related to mixes.
It's a rather odd situation as you need to use the v2 endpoint to return a list of something that you then actually only ever need the name and ID of really.
I'll push a draft PR to make what I'm talking about a bit more tangible.