Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snippets to use multiple language variants #1718

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Update snippets to use multiple language variants #1718

wants to merge 15 commits into from
+176 −119

Conversation

AndreasArvidsson
Copy link
Collaborator

@AndreasArvidsson AndreasArvidsson commented Feb 1, 2025 •
edited
Loading

  • Added actions to get multiple snippets for the same name. Can be used by extensions like Cursorless to make better decisions about which snippet to use.
  • Simplified the snippet code and added stronger types
  • Only update Talon lists if they have actually changed.

Fixes #1707
Fixes #1373

This was referenced Feb 1, 2025
Open
Open
nriley
nriley requested changes Feb 1, 2025
View reviewed changes
core/snippets/snippets.py Outdated Show resolved Hide resolved
core/snippets/snippets.py Outdated Show resolved Hide resolved
core/snippets/snippets.py Outdated Show resolved Hide resolved
core/snippets/snippets.py Show resolved Hide resolved
core/snippets/snippets.py Outdated Show resolved Hide resolved
core/snippets/snippets.py Outdated Show resolved Hide resolved
core/snippets/snippets.py Outdated Show resolved Hide resolved
nriley
nriley requested changes Feb 1, 2025
View reviewed changes
core/snippets/snippets.py Outdated Show resolved Hide resolved
core/snippets/snippets.py Outdated Show resolved Hide resolved
@AndreasArvidsson
Copy link
Collaborator Author

AndreasArvidsson commented Feb 1, 2025 •
edited
Loading

@nriley Requested changes have been made

@knausj85 Do you mind testing this?

knausj85
knausj85 approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@knausj85 knausj85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nriley nriley nriley requested changes

@knausj85 knausj85 knausj85 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend snippet functionality Make snippet watcher more fine-grained
3 participants
@AndreasArvidsson @nriley @knausj85