Fixed a bug in version detection#661
Merged
takapi327 merged 1 commit intoseries/0.6.xfrom Feb 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Details
We verified and confirmed a bug where the
Version.compare()method returned-1instead of0when comparing equivalent versions, through 30 tests. This bug affected all of the following callersDatabaseMetaDataImpl:compare(Version(9, 3, 0)) match case 1 =>pattern (4 locations) incorrectly branches to the legacy path when the exact version is 9.3.0DatabaseMetaDataImpl:compare(Version(5, 6, 4)) >= 0pattern (4 locations) incorrectly evaluates tofalsewhen the exact version is 5.6.4CachingSha2PasswordPlugin: Uses old transformation when version is exactly 8.0.5CharsetMapping.isOkayForVersion(): Returnsfalsefor equivalent versions (should returntrue)Pull Request Checklist
References