Skip to content

Fixed a bug in version detection#661

Merged
takapi327 merged 1 commit intoseries/0.6.xfrom
bugfix/2026-02-Fixed-bug-version-detection
Feb 24, 2026
Merged

Fixed a bug in version detection#661
takapi327 merged 1 commit intoseries/0.6.xfrom
bugfix/2026-02-Fixed-bug-version-detection

Conversation

@takapi327
Copy link
Owner

@takapi327 takapi327 commented Feb 24, 2026

Implementation Details

We verified and confirmed a bug where the Version.compare() method returned -1 instead of 0 when comparing equivalent versions, through 30 tests. This bug affected all of the following callers

  • DatabaseMetaDataImpl: compare(Version(9, 3, 0)) match case 1 => pattern (4 locations) incorrectly branches to the legacy path when the exact version is 9.3.0
  • DatabaseMetaDataImpl: compare(Version(5, 6, 4)) >= 0 pattern (4 locations) incorrectly evaluates to false when the exact version is 5.6.4
  • CachingSha2PasswordPlugin: Uses old transformation when version is exactly 8.0.5
  • CharsetMapping.isOkayForVersion(): Returns false for equivalent versions (should return true)

Pull Request Checklist

  • Wrote unit and integration tests
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code formatting by scalafmt (sbt scalafmtAll command execution)
  • Add copyright headers to new files

References

@takapi327 takapi327 mentioned this pull request Feb 24, 2026
13 tasks
@takapi327 takapi327 added 🪲 bug Something isn't working ldbc:connector Addition and modification of functionality to Connector projects labels Feb 24, 2026
@takapi327 takapi327 added this to the 0.6.0 milestone Feb 24, 2026
@takapi327 takapi327 self-assigned this Feb 24, 2026
@takapi327 takapi327 merged commit 4b0894b into series/0.6.x Feb 24, 2026
51 of 55 checks passed
@takapi327 takapi327 deleted the bugfix/2026-02-Fixed-bug-version-detection branch February 24, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪲 bug Something isn't working ldbc:connector Addition and modification of functionality to Connector projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant