v2/logging: add support for S3 logstreaming #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added support for S3 logstreaming endpoints to our API. This involved adding several new fields on the GET LogstreamConfiguration and PUT LogstreamConfiguration endpoints (and a new destinationType, "s3"), plus a new AWSExternalID resource and two new endpoints related to it. This commit updates the Go client library to reflect all of these changes. Updates tailscale/corp#24533 Signed-off-by: Zach Hauser <[email protected]>
oxtoacart
reviewed
Jan 23, 2025
| // CreateOrGetAwsExternalId gets an AWS External ID that Tailscale can use to stream logs to | ||
| // a LogstreamS3Endpoint using S3RoleARNAuthentication, creating a new one for this tailnet | ||
| // when necessary. | ||
| func (lr *LoggingResource) CreateOrGetAwsExternalId(ctx context.Context, request CreateOrGetAwsExternalIdRequest) (*AWSExternalID, error) { |
There was a problem hiding this comment.
You could just make reusable a parameter on this function, so that callers don't have to mess with constructing a CreateOrGetAwsExternalIdRequest. In general, we follow that sort of pattern, as seen here.
oxtoacart
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added support for S3 logstreaming endpoints to our API. This involved adding several new fields on the GET LogstreamConfiguration and PUT LogstreamConfiguration endpoints (and a new destinationType, "s3"), plus a new AWSExternalID resource and two new endpoints related to it.
This commit updates the Go client library to reflect all of these changes.
Updates tailscale/corp#24533