v2: return ETag with ACL and raw ACL responses #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
percy/issue119
branch
from
c78f9f8 to
2e718af
Compare
bradfitz
reviewed
Oct 25, 2024
v2/policyfile.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| acl.ETag = header.Get("ETag") |
There was a problem hiding this comment.
If you spell it the Go canonical way (Etag) here you avoid an alloc.
bradfitz
reviewed
Oct 25, 2024
v2/policyfile.go
Outdated
| return string(resp), nil | ||
| return &RawACL{ | ||
| HuJSON: string(resp), | ||
| ETag: header.Get("ETag"), |
|
(both are just FYIs, not blockers) |
This allows clients to know which ETag to provide when updating an ACL. Updates #119 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/issue119
branch
from
2e718af to
9fd0dbe
Compare
mpminardi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients to know which ETag to provide when updating an ACL.
Updates #119