Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add C++ tests on AMDGPU RHI #6597

Merged
merged 12 commits into from
Dec 30, 2022
Merged

Conversation

galeselee
Copy link
Contributor

@galeselee galeselee commented Nov 14, 2022

Issue: ##6434

Add some unit tests on the AMDGPU RHI level

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit dd41833
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63ae65f11f689f000830b4ba

@galeselee galeselee changed the title [ci] Add C++ tests on AMDGPU RHI device [ci] Add C++ tests on AMDGPU RHI Nov 14, 2022
@galeselee galeselee marked this pull request as draft November 14, 2022 15:42
@galeselee galeselee requested a review from turbo0628 November 14, 2022 17:22
@galeselee galeselee marked this pull request as ready for review November 14, 2022 17:22
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!
let's make sure we add an amd machine in ci before merging this PR tho ;)

tests/cpp/backends/amdgpu_device_test.cpp Show resolved Hide resolved
tests/cpp/backends/amdgpu_device_test.cpp Outdated Show resolved Hide resolved
tests/cpp/backends/amdgpu_device_test.cpp Outdated Show resolved Hide resolved
@galeselee galeselee merged commit abb0208 into taichi-dev:master Dec 30, 2022
galeselee added a commit that referenced this pull request Dec 30, 2022
Issue: ##6434

### Brief Summary
It contains four parts(`driver`, `context`, `device` and
`caching_allocator`). The code is similar to `cuda/rhi`. However, there
are still some differences between `amdgpu/rhi` and `cuda/rhi`
#### context
1. The method of obtaining the hardware version
2. Context::launch
#### driver
1. ROCm/hip internal functions
#### cmake

The current cmake compilation system is sufficient to support the Unit
test in #6597

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@galeselee galeselee deleted the amdgpu_rhi_ut branch December 31, 2022 04:09
feisuzhu pushed a commit to feisuzhu/taichi that referenced this pull request Jan 5, 2023
Issue: #taichi-dev#6434

Add some unit tests on the AMDGPU RHI level

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
feisuzhu pushed a commit to feisuzhu/taichi that referenced this pull request Jan 5, 2023
Issue: #taichi-dev#6434

### Brief Summary
It contains four parts(`driver`, `context`, `device` and
`caching_allocator`). The code is similar to `cuda/rhi`. However, there
are still some differences between `amdgpu/rhi` and `cuda/rhi`
#### context
1. The method of obtaining the hardware version
2. Context::launch
#### driver
1. ROCm/hip internal functions
#### cmake

The current cmake compilation system is sufficient to support the Unit
test in taichi-dev#6597

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #taichi-dev#6434

Add some unit tests on the AMDGPU RHI level

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #taichi-dev#6434

### Brief Summary
It contains four parts(`driver`, `context`, `device` and
`caching_allocator`). The code is similar to `cuda/rhi`. However, there
are still some differences between `amdgpu/rhi` and `cuda/rhi`
#### context
1. The method of obtaining the hardware version
2. Context::launch
#### driver
1. ROCm/hip internal functions
#### cmake

The current cmake compilation system is sufficient to support the Unit
test in taichi-dev#6597

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants