-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitoring XP drop #3679
Merged
Merged
Monitoring XP drop #3679
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
93ff71a
Monitoring XP drop
ioay 35b39c7
Added threshold period to drop XP notifications - 24h
ioay 6628484
Adjustment notifications message on XP drop
ioay fa6bf19
Set notification threshold on 30sec for testing purposes
ioay f809971
Fix eslint rules
ioay 02ff7de
Notifications XP drop threshold time changed to 24h
ioay eede991
Set notification permission flag when extension refreshed, chrome -> …
ioay 62a8399
Added browser support
ioay c14019c
Moved drop XP notifiaction method to notification service; change pro…
ioay e4022c9
Added default value for notification permission
ioay 6ca95eb
Reordeing emitter call
ioay 274c695
Change dependency injection pattern to events as a message bus
ioay 504ceb6
Add initializeNotificationsPreferences emitter
ioay d06cc45
Set notification permission on init when set in db
ioay aa7dbbd
Added callback when notification clicked
ioay 80b21ab
Removed unused import
ioay f76595b
Back to previous version of webextension
ioay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but we should have an extension-local URL available for this I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we can do it, also for the wallet-connection-handler (the same approach).