Fix e2e tests #3651
Merged
Fix e2e tests #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the NFT collection was changed from `Notable Crypto Punks` to `Notable Punks`. We're updating e2e tests to reflect that.
Previously when constructing an array of the seed words, we didn't verify that the words are already loaded, which could result in returning an empty array. Now we make sure all 24 words are present before creating the array with seed phrase words.
Thanks to the upgrade we're able to access new functionalities, e.g. UI Mode.
It looks that after upgrading to the latest version of Playwright something
has changed in the way how some locators work. The `.getByRole("button", { name:
"Select token", exact: true })` locator no longer identified the button we
wanted to click on the Swap screen. In this commit we're changing the location
method.
Previously a space character before the 'AM'/'PM' in the date was a character with `U+202F` unicode (narrow no-break space). Now the space character is coded as `U+0020` (regular space). We'e updating the e2e tests to reflect this change.
Recently the signing in with Ethereum on login.xyz started to misbehave. The old behavior was that there was a `Vote for your favorite emoji` poll visible on the website after confirming SIWE in the wallet. Now the website shows the same state as before the signing. In website console there's a `Cannot read properties of undefined (reading 'vote')` error. The issue got reported on https://discord.com/channels/862419652286218251/886997073650655232/1173226370776694794. We've been using login.xyz in our automated tests when checking SIWE. Until the issue is fixed, we're marking the test as expected to fail. That means that the test will be marked in logs as passed when there's no `Vote for your favorite emoji` on the page after signing. If the string will be found, Playwright will log a failure and will print `Expected to fail, but passed.`. Placing the `test.fail()` expression just before the failing step makes sure that failures on earlier stages will not be considered as expected and will still be flagged.
jagodarybacka
previously approved these changes
Nov 13, 2023
|
|
||
| // If we see this then it means we were able to sign in | ||
| // There's a bug on login.xyz that makes the test fail | ||
| // (https://discord.com/channels/862419652286218251/886997073650655232/1173226370776694794). |
There was a problem hiding this comment.
I doubt storing the discord links in a code is a good way to document it 😅 Is the login.xyz website open source? Can we add an issue somewhere?
There was a problem hiding this comment.
Unfortunately not, btw. I checked on Friday :)
There was a problem hiding this comment.
Yep, I also prefer documenting such issues in GH, but did not find a repo for the project, hence I contacted them via Discord and documented that.
Btw, I did get a response - they will look into the issue.
|
Ugh I see there is something else failing again on e2e flow, could you take a look? |
There is a bug in the wallet which manifests with the snackbar with the action's status not displaying after that action. This happens sporadically and does not mean that the action wasn't successful. We want to be notified when the bug occurs, but we don't want it to block execution of the subsequent steps. That's why we use the soft assertions.
I wasn't able to reproduce the failure locally, but I think it was caused by the #3675 bug. As we will likely want to fix the #3675 soon, I did not do any changes to the tests in relation to this bug. I did a different change though (f0441b1), so I need a new review. |
jagodarybacka
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Sorry for the double update, Github glitched
Looks good but we will need @Shadowfiend to approve because I'm not in a code owners group
4 tasks
Shadowfiend
approved these changes
Nov 20, 2023
Merged
Shadowfiend
added a commit
that referenced
this pull request
Nov 23, 2023
## What's Changed * Check connecting to dapp on different network after disconnecting by @michalinacienciala in #3654 * v0.51.0 by @Shadowfiend in #3652 * Fix typos by @xiaolou86 in #3668 * Alchemic Logs: Small improvements for eth_getLogs by @Shadowfiend in #3664 * Fix getting currently connected dapp info by @jagodarybacka in #3671 * Add static subcape link to the wallet by @jagodarybacka in #3670 * Fix e2e tests by @michalinacienciala in #3651 * Add Alchemy endpoint for Arbitrum Sepolia by @jagodarybacka in #3665 * Do notify: Set up base NotificationService by @Shadowfiend in #3666 ## New Contributors * @xiaolou86 made their first contribution in #3668 **Full Changelog**: v0.51.0...v0.52.0 Latest build: [extension-builds-3678](https://github.com/tahowallet/extension/suites/18415208655/artifacts/1067210815) (as of Wed, 22 Nov 2023 14:53:11 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues with the e2e tests we've been experiencing lately (and also upgrades Playwrght to the latest stable version). Changes made:
Select tokenelement, because it stopped working after upgrading to newer Playwright versionsigning.spec.tsas expected to fail because of the bug onlogin.xyz. Playwright will treat the test as passing when the step fails and will mark the test as failed if the step passes.Latest build: extension-builds-3651 (as of Mon, 20 Nov 2023 15:39:07 GMT).