Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP-7524 (PLUME Signatures) #3638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orenyomtov
Copy link

@orenyomtov orenyomtov commented Oct 6, 2023

Explanation

We want Taho to be the first wallet to support private voting and private airdrops on Ethereum and other EVM chains.

This PR adds new eth_getPlumeSignature RPC method that implements a novel ECDSA nullifier scheme as described in EIP-7524.

The eth_getPlumeSignature method takes in two parameters, a message and an address, then generates a deterministic signature (PLUME) and several other inputs. The plume can be used as a nullifier to prevent double-spending in an anonymity set. This capability unlocks novel on-chain behavior, such as private DAO voting, fair, non-doxxing airdrops, and more.

Screenshot

plume confirmation window

Manual Testing Steps

After building and running Taho locally, enter this into the browser console

await window.ethereum.request({
  "method": "eth_requestAccounts",
  "params": []
});

accountAddress = (await window.ethereum.request({
  "method": "eth_accounts",
  "params": []
}))[0];

await window.ethereum.request({
  "method": "eth_getPlumeSignature",
  "params": [
    "this is a test message - hi aayush",
    accountAddress
  ]
});

A confirmation screen should open up. After clicking "Sign", you will see the plume and other signals outputted into the console.

Discussion

Discord thread

@mhluongo
Copy link
Contributor

mhluongo commented Nov 2, 2023

Umm, this is really cool! @orenyomtov could we get some more context on what you want to support here first?

@Divide-By-0
Copy link

Divide-By-0 commented Feb 7, 2024

in the last month, 3 more protocols have voiced a clear demand for this:

gitcoin passport wants this feature asap so they can have nullifiers with eth addresses to avoid passport attestations involving ZK from being double-used [happy to link to the PM there or send a screenshot of a chat from him]
summa (proof of solvency/reserves) for CEXs requires PLUME to work without the exchanges revealing their balances, and is the main blocker
zksnap (private voting) is what ameen called the "holy grail" of private voting tradeoffs and requires plume as a critical component of the proofs

as these zk apps and usecases hit mainnet, we are hoping wallets want to be part of upcoming ZK applications -- we have open convos with metamask, rabby, and ledger now as well as PRs in progress for all of them, and will open more convos in the coming months :)

@Divide-By-0
Copy link

Umm, this is really cool! @orenyomtov could we get some more context on what you want to support here first?

@mhluongo Not exactly sure by what you mean about what we want to 'support here first', but the idea is that we want Taho users to be able to generate PLUME signatures using existing wallets. This PR adds the cryptographic, RPC, and UI functionality to do so. This would let them subsequently generate the needed ZK proofs on applications of their choosing (gitcoin passport for instance is blocked on this problem for their zk attestations).

@mhluongo
Copy link
Contributor

What happens here when a user is using a Ledger?

@Divide-By-0
Copy link

What happens here when a user is using a Ledger?

Hey! We have a specific PR available to Ledger devices as well right now, and are working on getting that approved as well in parallel. So we would simply call something like eth_getPlumeSignature on the Ledger, but we haven't added that yet because we haven't merged the Ledger PR yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants