Skip to content

Commit

Permalink
fix(chalice): fixed get heatmap with incomplete payload
Browse files Browse the repository at this point in the history
  • Loading branch information
tahayk committed Jul 8, 2024
1 parent d241b0b commit 4b6f448
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
7 changes: 5 additions & 2 deletions api/chalicelib/core/custom_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -692,9 +692,12 @@ def make_chart_from_card(project_id, user_id, metric_id, data: schemas.CardSessi
data=data.model_dump())
elif metric.metric_type == schemas.MetricType.heat_map:
if raw_metric["data"] and raw_metric["data"].get("sessionId"):
return heatmaps.get_selected_session(project_id=project_id, session_id=raw_metric["data"]["sessionId"])
return heatmaps.get_selected_session(project_id=project_id,
session_id=raw_metric["data"]["sessionId"])
else:
return heatmaps.search_short_session(project_id=project_id, data=metric, user_id=user_id)
return heatmaps.search_short_session(project_id=project_id,
data=schemas.HeatMapSessionsSearch(**metric.model_dump()),
user_id=user_id)

return get_chart(project_id=project_id, data=metric, user_id=user_id)

Expand Down
7 changes: 5 additions & 2 deletions ee/api/chalicelib/core/custom_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -739,9 +739,12 @@ def make_chart_from_card(project_id, user_id, metric_id, data: schemas.CardSessi
data=data.model_dump())
elif metric.metric_type == schemas.MetricType.heat_map:
if raw_metric["data"] and raw_metric["data"].get("sessionId"):
return heatmaps.get_selected_session(project_id=project_id, session_id=raw_metric["data"]["sessionId"])
return heatmaps.get_selected_session(project_id=project_id,
session_id=raw_metric["data"]["sessionId"])
else:
return heatmaps.search_short_session(project_id=project_id, data=metric, user_id=user_id)
return heatmaps.search_short_session(project_id=project_id,
data=schemas.HeatMapSessionsSearch(**metric.model_dump()),
user_id=user_id)

return get_chart(project_id=project_id, data=metric, user_id=user_id)

Expand Down

0 comments on commit 4b6f448

Please sign in to comment.