fix ui: fix reader byte skipping, add pause on css loading screen (op…

…enreplay#2058)
tahayk · Apr 8, 2024 · 3807ebb · 3807ebb
1 parent de402d4
commit 3807ebb
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/frontend/app/components/Session/WebPlayer.tsx b/frontend/app/components/Session/WebPlayer.tsx
@@ -65,7 +65,10 @@ function WebPlayer(props: any) {
     }
   }, [session.sessionId]);
 
-  const { firstVisualEvent: visualOffset, messagesProcessed } = contextValue.store?.get() || {};
+  const { firstVisualEvent: visualOffset, messagesProcessed, tabStates, ready } = contextValue.store?.get() || {};
+  const cssLoading = ready && tabStates ? Object.values(tabStates).some(
+    ({ cssLoading }) => cssLoading
+  ) : true
 
   React.useEffect(() => {
     if (messagesProcessed && (session.events.length > 0 || session.errors.length > 0)) {

diff --git a/frontend/app/player/mobile/IOSMessageManager.ts b/frontend/app/player/mobile/IOSMessageManager.ts
@@ -282,7 +282,7 @@ export default class IOSMessageManager implements IMessageManager {
   setMessagesLoading = (messagesLoading: boolean) => {
     this.screen.display(!messagesLoading);
     // @ts-ignore idk
-    this.state.update({ messagesLoading, ready: !messagesLoading && !this.state.get().cssLoading });
+    this.state.update({ messagesLoading, ready: !messagesLoading });
   };
 
   private setSize({ height, width }: { height: number; width: number }) {

diff --git a/frontend/app/player/web/MessageManager.ts b/frontend/app/player/web/MessageManager.ts
@@ -63,6 +63,7 @@ export interface State extends ScreenState {
   currentTab: string;
   tabs: Set<string>;
   tabChangeEvents: TabChangeEvent[];
+  sessionStart: number;
 }
 
 export const visualChanges = [
@@ -90,6 +91,7 @@ export default class MessageManager {
     currentTab: '',
     tabs: new Set(),
     tabChangeEvents: [],
+    sessionStart: 0,
   };
 
   private clickManager: ListWalker<MouseClick> = new ListWalker();
@@ -116,6 +118,7 @@ export default class MessageManager {
   ) {
     this.mouseMoveManager = new MouseMoveManager(screen);
     this.sessionStart = this.session.startedAt;
+    state.update({ sessionStart: this.sessionStart });
     this.activityManager = new ActivityManager(this.session.duration.milliseconds); // only if not-live
   }
 
@@ -325,8 +328,9 @@ export default class MessageManager {
       this.updateChangeEvents();
     }
     this.screen.display(!messagesLoading);
-    // @ts-ignore idk
-    this.state.update({ messagesLoading, ready: !messagesLoading && !this.state.get().cssLoading });
+    const cssLoading = Object.values(this.state.get().tabStates).some((tab) => tab.cssLoading);
+    const isReady = !messagesLoading && !cssLoading
+    this.state.update({ messagesLoading, ready: isReady});
   };
 
   decodeMessage(msg: Message) {

diff --git a/frontend/app/player/web/messages/MFileReader.ts b/frontend/app/player/web/messages/MFileReader.ts
@@ -56,6 +56,9 @@ export default class MFileReader extends RawMessageReader {
    * */
   private readRawMessage(): RawMessage | null {
     try {
+      if (!this.noIndexes) {
+        this.skip(8)
+      }
       return super.readMessage()
     } catch (e) {
       this.logger.error("Read message error:", e)