Update region to extended TagoIO Deploy support #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… imports to use Vitest, and adjust function parameters for consistency
…nstead of hardcoded value
vitorfdl
changed the title
cotrin
requested changes
Nov 26, 2024
|
|
||
| let { networkID, connectorID } = options; | ||
|
|
||
| const account = new Account({ token: config.profileToken, region: "usa-1" }); |
There was a problem hiding this comment.
is this region fixed to "usa-1"? Should it not be using the return type from getEnvironmentConfig (config.profileRegion)?
…export and config commands
…elds, removing deprecated ones
cotrin
previously approved these changes
Nov 27, 2024
cotrin
dismissed
their stale review
didn't see one of the coments was still unresolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend support to TagoDeploy on every function by replacing hardcoded region values with profileRegion for improved consistency.
Requirements