Add RA02G Decoder for Netvox Sensor over LoRaWAN #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This connector is currently working successfully on our CityKinect account, under the device name "Netvox RA02G." All features and parsing functionalities have been tested and validated. Please let us know if you need any further information. |
|
Thank you @nishchayjeet I'll be reviewing this PR tomorrow and hopefully it will be approved! :) |
Freddyminu
requested changes
Dec 6, 2024
| @@ -0,0 +1 @@ | |||
| # Wireless Cigarette Smoke, Vaping, and Bullying Alarm Sensor over LoRaWAN™ | |||
| { | ||
| "$schema": "../../../../../schema/connector_details.json", | ||
| "description": "../description.md", | ||
| "install_text": "\nRA02G is a smart indoor sensor designed for high-reliability wireless control and alarm detection. It detects smoke, noise, and tampering, providing versatile alarm functionality over LoRaWAN™.\n\nMore information about this device can be found [here.](http://www.netvox.com.tw/products.asp?pro=RA02G) \n", |
There was a problem hiding this comment.
Please remove or update the link, It's broken.
| "device_annotation": "Wireless cigarette smoke, vaping, and anti-tampering alarm sensor with customizable audio alerts and power outage detection.", | ||
| "device_parameters": [], | ||
| "networks": [ | ||
| "../../../../network/lorawan-citykinect/v1.0.0/payload.js", |
There was a problem hiding this comment.
Just a reminder: Make sure you've added all the networks this connector can be used with.
| */ | ||
|
|
||
| const ignore_vars = []; | ||
|
|
There was a problem hiding this comment.
Please add unit tests in order to make sure the connector is working. Please use the Netvox R312a as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoder Description
Explain the functionality of your decoder or any other relevant information.
Type of change
Decoder Information and Payload to test and review
Checklist for Adding a New Decoder
./decoders/network/or./decoders/connector/with the name of your decoder.network.jsoncorconnector.jsoncfile that follows the structure defined in./schema/.manifest.jsoncfiles for each version.Additional Notes
Please add any other information that you think is important.