Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make escape and it variants take a impl Into<Cow<str>> argument and implement From<(&'a str, Cow<'a, str>)> on Attribute #827

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Oct 20, 2024

No description provided.

@Tpt
Copy link
Contributor Author

Tpt commented Oct 20, 2024

Handy to easily create Attribute from owned values without having to play with lifetimes. Note sure if it's the best approach, feel free to suggest an other one or reject this PR.

@Tpt Tpt force-pushed the escape branch 2 times, most recently from 87c5fe0 to dc0f5a2 Compare October 20, 2024 13:59
…nd implement `From<(&'a str, Cow<'a, str>)>` on `Attribute`
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.19%. Comparing base (a9391f3) to head (786bee1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/events/attributes.rs 0.00% 7 Missing ⚠️
src/events/mod.rs 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   60.21%   60.19%   -0.02%     
==========================================
  Files          41       41              
  Lines       16021    16030       +9     
==========================================
+ Hits         9647     9650       +3     
- Misses       6374     6380       +6     
Flag Coverage Δ
unittests 60.19% <40.90%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mingun Mingun merged commit 3197e64 into tafia:master Oct 20, 2024
7 checks passed
@Tpt Tpt deleted the escape branch October 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants