First version of partial evaluator: support for +,-,* operators and associative rules #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still some TODOs (so, this is only a partial commit): - Implementation of association rule 3 and simple algebraic rules (to be added to file algebraic.ts) described in comments of issue: #435 - Processing of structs, function calls, id lookups, ternary conditional operator. - Extensive documentation, specially in the description of what each rule does. - Extensive testing of the rewrite rules.
…Priorities are no longer a property of rules, but are managed by the optimizer.
…ded a function to call the partial evaluator in the interpreter to ease testing.
|
@jeshecdom awesome stuff! could you please update your PR and pull in the most recent changes from |
anton-trunov
requested changes
Jul 5, 2024
…-lang/tact/pull/528/files#r1666596822) - Added `dummySrcInfo` as default parameter values to functions `__evalUnaryOp` and `__evalBinaryOp`. This way I was able to eliminate them and simply leave `evalUnaryOp` and `evalBinaryOp` as exportable functions. (https://github.com/tact-lang/tact/pull/528/files#r1666598821) - Renamed ValueExpression for AstValue (https://github.com/tact-lang/tact/pull/528/files#r1666602072) - Used Dummy interval in grammar.ts (https://github.com/tact-lang/tact/pull/528/files#r1666602072) - Changed interfaces for abstract classes (https://github.com/tact-lang/tact/pull/528/files#r1666604615) - Renamed `areEqualExpressions` to `eqExpressions`, and moved it to `ast.ts`. Used `eqNames` and moved `ast1.kind === ast2.kind` check before switch. (https://github.com/tact-lang/tact/pull/528/files#r1666609433)
|
There are merge conflicts |
anton-trunov
requested changes
Jul 11, 2024
- Added test cases for eqExpressions function in ast.ts. - Changed if statement for conditional expressions in optimizer/util.ts. - Changed lookupID for lookupName and evalX for fullyEvalX in constEval.ts.
anton-trunov
requested changes
Jul 13, 2024
- Moved AstValue to ast.ts. - Removed try/catch from eqExpressions in ast.ts. - Removed `traverse` from ast.ts since it has been already moved to iterators.ts - Moved expr-equality.spec.ts and partial-eval.spec.ts to src/grammar/test - Added test cases for `isValue' function in ast.ts in src/grammar/test/expr-is-value.spec.ts.
anton-trunov
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #435.
First version of partial evaluator. Currently it is able to simplify expressions involving +, -, and *. However, there are some algebraic rules involving those operators that have not been added yet.
I decided to keep the partial evaluator separate from the constant evaluator because the partial evaluator still does not support certain language constructions, like structs: the partial evaluator needs to create AST nodes out of values, and there is currently no code to construct ASTStruct nodes out of StructValue. This will be added in the future.
Currently, to call the partial evaluator, one needs to call the function
partiallyEvalExpression. In the future, the constant evaluator will call the partial evaluator, because they should give the same result for expressions that can fully evaluate.Many algebraic rules are still pending, including the rest of integer operators and boolean operators.
Still lacks documentation, specially the explanation of how each rule works.
Since the partial evaluator is currently isolated from the rest of the code, the tests directly check the partial evaluator instead of going through a contract.
I have updated CHANGELOG.md
[ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBERI have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
I have run all the tests locally and no test failure was reported
I have run the linter, formatter and spellchecker
I did not do unrelated and/or undiscussed refactorings