Separate test runner and other imrovements #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0838
changed the title
danny0838
force-pushed
the
main
branch
3 times, most recently
from
b84d3ff
to
4ebbcc5
Compare
|
Nope, it's purely been a matter of me not having the time to review them. |
- Separate the test runner script to a new test.js file so that the developers of other projects can import and run the test cases on their own.
- This prevents the parseerror message show "0x-1". - There is no \x00, which has been replaced during preprocessing, in the input codepoints.
- Wrap internal variables in a closure to prevent repeated instantiation when called. - Define every internal function using a direct function expression rather than an anonymous function.
|
Rebased on top of #59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the commit messages.