Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #374 (Crash with numpy version 1.15 and above (function np.product removed)) #375

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

osvalB
Copy link

@osvalB osvalB commented Oct 29, 2024

Fixes Issue #374. Based on the numpy version, fit.py decides if np.prod or np.product should be used.

@tBuLi
Copy link
Owner

tBuLi commented Nov 1, 2024

Thank you for supplying this fix!

LooseVersion does raise the following warning: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead. Perhaps you could switch to that recommended solution?

And the automated tests also give ImportError: cannot import name 'simps' from 'scipy.integrate', it seems that simps has been renamed simpson... Would you mind applying the same patch for that import error?

@osvalB
Copy link
Author

osvalB commented Nov 3, 2024

Happy to help. I changed to 'packaging.version' and also changed 'simps' to 'simpson' according to the scipy version. Best, Os

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants