Expo 52

[czystyl]

Update the Mobile app to use Expo v52 and related packages.

Additionally:

• fixes bug: Readme schema link is broken #1246
• fixes The field "cli.appVersionSource" is not set, but it will be required in the future. warning
• Move splash screen configuration to plugin config source

[kiikoh]

EXPO_USE_METRO_WORKSPACE_ROOT is now enabled by default. The monorepo root is considered to "contain all content", the workspace root adds something called "server root" besides the "project root". This fixes a couple of things related to: resolution to workspaces in the monorepo, splitting the Metro cache for near-identical apps in the same monorepo, using the correct entry point resolution in various cases.
Metro will now be automatically configured to support pnpm monorepos. Learn more.

From: https://expo.dev/changelog/2024/11-12-sdk-52

Is there any simplifications that can be made to the metro configuration as a result of this? Can hoist be removed?

[VaniaPopovic]

Can we bump nativewind + remove "react-native-css-interop": "~0.0.36", as part of this? Nativewind 4.1.x contains a lot of fixes

P.S think there are some changes in expo-splash-screen as well

[czystyl]

Can we bump nativewind + remove "react-native-css-interop": "~0.0.36", as part of this? Nativewind 4.1.x contains a lot of fixes

P.S think there are some changes in expo-splash-screen as well

Is react-native-css-interop not needed anymore?

[czystyl]

EXPO_USE_METRO_WORKSPACE_ROOT is now enabled by default. The monorepo root is considered to "contain all content", the workspace root adds something called "server root" besides the "project root". This fixes a couple of things related to: resolution to workspaces in the monorepo, splitting the Metro cache for near-identical apps in the same monorepo, using the correct entry point resolution in various cases.
Metro will now be automatically configured to support pnpm monorepos. Learn more.

From: https://expo.dev/changelog/2024/11-12-sdk-52

Is there any simplifications that can be made to the metro configuration as a result of this? Can hoist be removed?

I don't see anything that can be simplified at this moment. I'm upgrading two other production apps that use monorepo, so If anything pops up, I'll transfer it here as well.

[czystyl]

I've encountered development build problems, so converting the PR back to draft.

[juliusmarminge]

we should be able to remove the hoisting now right? Expo 52 promised to fix monorepos 🤞🏼

[juliusmarminge]

@VaniaPopovic will run some sanity checks tomorrow (potentially add back granular hoisting since EAS might not play nice otherwise) but LGTM :)

[czystyl]

@VaniaPopovic will run some sanity checks tomorrow (potentially add back granular hoisting since EAS might not play nice otherwise) but LGTM :)

Thanks @juliusmarminge, for jumping in!

I've had weird issues with the build itself, but let me know if you need anything else to test.

[kiikoh]

FWIW: I also had issues applying these changes to my t3-turbo project but had problems getting it to build properly. Although its very possible that my issues are from the additional packages I've added

[czystyl]

I've tested the build after @juliusmarminge changes, and it works like a charm!

[kiikoh]

I had problems building with the hoist option disabled, adding it back allowed it to work

[czystyl]

From today's testing (iOS builds):

• Local builds (using Xcode) works without node-linker=hoisted
• EAS builds breaks without node-linker=hoisted

Eas logs:

▸ ** BUILD FAILED **
▸ The following build commands failed:
▸ 	PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images /Users/expo/workingdir/build/apps/expo/ios/build/Build/Intermediates.noindex/expo.build/Release-iphonesimulator/expo.build/Script-00DD1BFF1BD5951E006B06BC.sh (in target 'expo' from project 'expo')
▸ 	Building workspace expo with scheme expo and configuration Release
▸ (2 failures)
** BUILD FAILED **
The following build commands failed:
	PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images /Users/expo/workingdir/build/apps/expo/ios/build/Build/Intermediates.noindex/expo.build/Release-iphonesimulator/expo.build/Script-00DD1BFF1BD5951E006B06BC.sh (in target 'expo' from project 'expo')
	Building workspace expo with scheme expo and configuration Release
(2 failures)
Exit status: 65```

[RobSchilderr]

Really looking forward to spend some time in christmas playing around with SDK 52! What's the status of this issue? I saw that the core of tRPC was bumped to 19 already

[czystyl]

@juliusmarminge From my test we'll need to bring back the hoisting because of ESA - it's not working well :D

[adriangonzy]

Hey guys ! I was able to have expo sdk 52 with react 18.3.1 and the new Arch on the expo app and react 19 every where else.

I had to change the package.json at the root on the CI like this:

      - name: PreInstall forcing React 18.3.1 on Mobile
        run: |
          rm pnpm-lock.yaml && 
          jq '.pnpm.overrides = {
            "react": "18.3.1",
            "react-dom": "18.3.1",
            "@types/react": "18.3.16",
            "@types/react-dom": "18.3.1"
          }' package.json > temp.json && mv temp.json package.json

I am forced to delete the lock file so the override works and we only have this react version when bundling the app.

The rest of the puzzle is as you described:

• using catalogs for the react versions so we avoid mistmatched versions of react on installation.
• no hoisting when working locally. I think its possible to make it work locally with hoisting but it might require some extra work on the metro resolver config.
• changing the hoisting on the CI when building -> like this:

      - name: Force hoisting on CI
        run: mv .npmrc-ci .npmrc && pnpm install

And .npmrc-ci has:

node-linker=hoisted
link-workspace-packages=true

Thanks for the many pieces that helped me get to this hacky solution waiting for react 19 to be officially supported on react native projects.

I also managed to upgrade Next to version 15 as I integrated payloadCMS v3 too.