Add Reviewing workflow to REVIEWING.md #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: theooprea <[email protected]>
razvand
requested changes
May 10, 2022
| @@ -8,6 +8,11 @@ As a reviewer, you will make sure that questions are of good quality: | |||
|
|
|||
| You will also need to have a good overview of existing questions in the repository to prevent duplicates. | |||
|
|
|||
| ## Table of contents | |||
There was a problem hiding this comment.
Suggested change
| ## Table of contents | |
| ## Table of contents | |
|
|
||
| ## Reviewing public pool repo contribution | ||
|
|
||
| <b>Starting</b>: There is a pending contribution to the public pool |
There was a problem hiding this comment.
Suggested change
| <b>Starting</b>: There is a pending contribution to the public pool | |
| **Starting**: There is a pending contribution to the public pool |
|
|
||
| <b>Starting</b>: There is a pending contribution to the public pool | ||
|
|
||
| <b>Workflow</b>: |
There was a problem hiding this comment.
Suggested change
| <b>Workflow</b>: | |
| **Workflow**: |
| <b>Starting</b>: There is a pending contribution to the public pool | ||
|
|
||
| <b>Workflow</b>: | ||
| * The reviewer goes through the pending contribution |
There was a problem hiding this comment.
Suggested change
| * The reviewer goes through the pending contribution | |
| * The reviewer goes through the pending contribution. |
|
|
||
| <b>Workflow</b>: | ||
| * The reviewer goes through the pending contribution | ||
| * The reviewer checks the questions' relevance, format, metadata, whether they are different from the existing questions, while following the Reviewing guidelines |
There was a problem hiding this comment.
Suggested change
| * The reviewer checks the questions' relevance, format, metadata, whether they are different from the existing questions, while following the Reviewing guidelines | |
| * The reviewer checks the questions' relevance, format, metadata, whether they are different from the existing questions, while following these guidelines. |
| * The reviewer checks the questions' relevance, format, metadata, whether they are different from the existing questions, while following the Reviewing guidelines | ||
| * If needed, the reviewer gives feedback and requests changes | ||
|
|
||
| <b>Result</b>: |
There was a problem hiding this comment.
Suggested change
| <b>Result</b>: | |
| **Result**: |
| * If needed, the reviewer gives feedback and requests changes | ||
|
|
||
| <b>Result</b>: | ||
| * The contribution is accepted and integrated in the private pool repo |
There was a problem hiding this comment.
Suggested change
| * The contribution is accepted and integrated in the private pool repo | |
| * The contribution is accepted and integrated in the private pool repository. |
| * The contribution is accepted and integrated in the private pool repo | ||
| * The contribution needs updates according to the feedback | ||
| * The contribution is rejected, for one of these reasons: | ||
| * The question is irrelevant, incorrect or unfixable |
There was a problem hiding this comment.
Suggested change
| * The question is irrelevant, incorrect or unfixable | |
| * The question is irrelevant, incorrect or unfixable. |
| * The contribution needs updates according to the feedback | ||
| * The contribution is rejected, for one of these reasons: | ||
| * The question is irrelevant, incorrect or unfixable | ||
| * The question already exists in the public pool repo |
There was a problem hiding this comment.
Suggested change
| * The question already exists in the public pool repo | |
| * The question already exists in the public pool repository. |
| * The contribution is rejected, for one of these reasons: | ||
| * The question is irrelevant, incorrect or unfixable | ||
| * The question already exists in the public pool repo | ||
| * The question already exists in the private pool repo |
There was a problem hiding this comment.
Suggested change
| * The question already exists in the private pool repo | |
| * The question already exists in the private pool repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: theooprea [email protected]