Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QPGS sensors for parallel or three phase #101

Closed
wants to merge 1 commit into from
Closed

Added QPGS sensors for parallel or three phase #101

wants to merge 1 commit into from

Conversation

gio-dot
Copy link

@gio-dot gio-dot commented Jan 4, 2024

@syssi I tried to decode commands in three phases (or parallel) configuration and implement it in PIP8048 component. I'm not a software expert, but i tried to use the correct syntax following existing commands. I added all this section to the component (fig.1).
I also tested QPGS commands on my PIP8048 three phase configuration and they reply as in the protocol (fig.2).

Esphome firmware using modified component compile and load correctly, all original component sensors works, but unfortunately the part that i added doesn't work. Sensors are NA. It seems that QPGSn command is sent but there is no reply (fig.3)

Can someone check if i missing something adding new command? This modification can be useful for those that want to use parallel or three phase configuration... Attached there is my modified component. Please tell me a better way to load it (maybe a new branch or a pull request?)

image

2024-01-03 20_31_57-Free Device Monitoring Studio

image

@gio-dot gio-dot closed this Jan 6, 2024
@syssi
Copy link
Owner

syssi commented Jan 7, 2024

Does it work now?

@gio-dot
Copy link
Author

gio-dot commented Jan 7, 2024

Does it work now?

I'm sorry, i closed my pr because i noticed Too late that a previous pr from another user already included qpgs sensors, so please ignore my unuseful work 😅🤯.
#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants