-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PIP8048 support #10
Open
syssi
wants to merge
116
commits into
main
Choose a base branch
from
pip8048
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
syssi
commented
Mar 12, 2022
•
edited
Loading
edited
- Add unit of measurement and device class = volt for CONF_BATTERY_REDISCHARGE_VOLTAGE
set CONF_CURRENT_MAX_CHARGING_CURRENT accuracy_decimals = 0
- Add charging_discharging_controls option for the PBATCD command (need to be tested)
-add charging_discharging_controls_select
- Add charging_discharging_controls select
- Add QBATCD
- Comment
-Revert
- Add CURRENT_MAX_AC_CHARGING_CURRENT & CURRENT_MAX_CHARGING_CURRENT
- Clean up different attempts
- Clearn up
- Clean up
- Add new selects
- Add new selects
This change is required by ESPHome 2023.4.0 See esphome/esphome#4446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.