Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve printf types to fix ESP32C6 compatibility #637

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Improve printf types to fix ESP32C6 compatibility #637

wants to merge 35 commits into from

Conversation

SupermotoJerry
Copy link

made some changes to fix issues I was having with ESP32C6
might be helpful to others
feel free to add comments or make edits (I'm new to GitHub)

@SupermotoJerry
Update jk_bms_ble.cpp
442c316 
ESP32-C6 Updates

Error Details:
Format specifier mismatch: You are passing a uint32_t (which is an unsigned 32-bit integer) but using format specifiers meant for int or unsigned int:
ESP_LOGD(TAG, "Time enter sleep: %u s", jk_get_32bit(238 + offset));
ESP_LOGI(TAG, " Uptime: %d s", jk_get_32bit(38));
ESP_LOGI(TAG, " Power on count: %d", jk_get_32bit(42));
Solution:
You should adjust the format specifiers to match the uint32_t type (which is the data type being returned by jk_get_32bit()).

For uint32_t (unsigned 32-bit integer), use %lu:
Change %u to %lu for unsigned 32-bit integers in the log messages.
Change %d to %ld for signed 32-bit integers if necessary.
@SupermotoJerry
Merge pull request #1 from syssi/main
94e2b7b 
Fix sensor names (syssi#634)
syssi
syssi approved these changes Dec 11, 2024
View reviewed changes
Copy link
Owner

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@syssi syssi changed the title made changes to support ESP32C6 Improve printf types to fix ESP32C6 compatibility Dec 11, 2024
SupermotoJerry
SupermotoJerry commented Dec 11, 2024
View reviewed changes
Copy link
Author

@SupermotoJerry SupermotoJerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@syssi
Copy link
Owner

syssi commented Dec 11, 2024

Are you sure these changes are required for your ESP32 model? Could you share your YAML configuration?

@SupermotoJerry
Copy link
Author

SupermotoJerry commented Dec 11, 2024 •
edited
Loading

Are you sure these changes are required for your ESP32 model? Could you share your YAML configuration?

I couldn't get it working without them.

Sure:

configuration.yaml.txt

@SupermotoJerry
Added MQTT auto-discovery
3a9849d
@SupermotoJerry
Update esp32-ble-example-multiple-devices.yaml
72b8028 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-example.yaml
9b6684a 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-jk04-example.yaml
50d3b1f 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-uart-hybrid-example.yaml
82e66a6 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-v11-example.yaml
4f58671 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-v14-example.yaml
e9f8cbc 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-v14-multiple.yaml
56ece20 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-display-example.yaml
340ee0f 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-example-multiple-devices.yaml
7a997b2 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-example.yaml
9287166 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-heltec-balancer-ble-example-multiple-devices.yaml
b61f65f 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-heltec-balancer-ble-example-multiple-devices.yaml
ff60ef3 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-heltec-balancer-ble-example.yaml
1af0541 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-jk-pb-modbus-example.yaml
efd9075 
added MQTT auto-discovery
@SupermotoJerry
Update esp8266-display-example.yaml
0d7cdee 
added MQTT auto-discovery
@SupermotoJerry
Update esp8266-example.yaml
5035e88 
added MQTT auto-discovery
@SupermotoJerry
Update esp8266-jk-pb-modbus-example.yaml
397967f 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-example-multiple-devices.yaml
e3b7ca3 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-example.yaml
bb58bee 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-jk04-example.yaml
ceec603 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-uart-hybrid-example.yaml
b0297d8 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-v11-example.yaml
1e6f932 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-v14-example.yaml
86db91a 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-v14-multiple.yaml
b8c5292 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-display-example.yaml
acbd39c 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-example-multiple-devices.yaml
fef27c1 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-example.yaml
f3b8a42 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-block-traffic.yaml
f77fa50 
added MQTT auto-discovery
@SupermotoJerry
Update esp32-ble-energy-dashboard.yaml
5908bf9 
added MQTT auto-discovery
@SupermotoJerry
Merge branch 'syssi:main' into main
56838cb
syssi
syssi requested changes Dec 25, 2024
View reviewed changes
Copy link
Owner

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this project doesn't compile anymore (without updating ESP-IDF). Furthermore you have introduced some more changes accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syssi syssi syssi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SupermotoJerry @syssi