Remove unittest's TestCase from top level package import. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale ======= When importing from `snapshottest` package this might result in confusion as the `TestCase` class name is used by multiple subpackages. Solution ====== Prevent wrong imports by using the `unittest` package.
jackton1
changed the title
|
This is good, but I only want to merge it with a major version release since this is a change in the public API. |
ayys
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When importing from
snapshottestpackage this might result in confusion as theTestCaseclass name is used by multiple subpackages.Solution
Prevent wrong imports by letting the caller specify the
unittestpackage explicitly in the import.