Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE 1.0.0b0 #141

Merged
merged 2 commits into from
Oct 3, 2020
Merged

RELEASE 1.0.0b0 #141

merged 2 commits into from
Oct 3, 2020

Conversation

paulmelnikow
Copy link
Collaborator

@paulmelnikow paulmelnikow commented Oct 2, 2020

These are the commits: 0.6.0...master

@medmunds mind taking a look at this too?

@davidshepherd7
Copy link
Collaborator

Hey, not sure what exactly you want reviewing here but releasing a 1.0 beta seems fine.

Can we merge #112 first?

@paulmelnikow
Copy link
Collaborator Author

Mainly the changelog. I don’t want to block on #112 to get validation on the Py3 updates. We can easily ship another beta. I’ll give #112 another read though.

@medmunds
Copy link
Collaborator

medmunds commented Oct 3, 2020

I'd kind of like to see #112 in before a 1.0-beta. Also, if we're about to introduce new django (and unittest) entry points and deprecate the old ones (#52 (comment)), I kind of think that should go in before the beta, too.

Could I suggest maybe releasing the current code as either 1.0-alpha, or maybe even just 0.7.0? My sense is very few people install pre-release versions, so if the goal is getting feedback on recent changes, 0.7.0 will maximize that. (Before 1.0, semver permits breaking changes in 0.x.0 releases.)

(I was always taught that after you reach beta, you should try to stick to bugfixes only—new features and API changes are strongly discouraged between beta and release. Though I realize different organizations have different definitions for beta.)

@paulmelnikow
Copy link
Collaborator Author

(I was always taught that after you reach beta, you should try to stick to bugfixes only—new features and API changes are strongly discouraged between beta and release. Though I realize different organizations have different definitions for beta.)

In Nock we shipped new features and breaking changes in beta releases for a whole year once. Though yea, different orgs and programming communities may have different expectations. I think the reason to make them betas is to signal that we prefer people use them and give feedback. Although I really don't mind releasing a bunch of alphas instead.

(Before 1.0, semver permits breaking changes in 0.x.0 releases.)

This is why I want to get into 1.x territory. Below 1.0, semver is pointless.

#112 still needs documentation. How about I ship this as 1.0.0a0, and then we can ship 1.0.0a1 after #112 lands?

Though major versions are expensive, releases are cheap.

Copy link
Collaborator

@medmunds medmunds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulmelnikow paulmelnikow merged commit 48528b7 into master Oct 3, 2020
@paulmelnikow paulmelnikow deleted the release-1.0.0b0 branch October 3, 2020 22:03
@medmunds
Copy link
Collaborator

@paulmelnikow could you tag this release in git? (I think the GitHub Releases page will offer to do that for you if you add a release there.)

@paulmelnikow
Copy link
Collaborator Author

Oops! All set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants