fix(transfer): remove 80% onchain cap, misc fixes #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
commented
Dec 17, 2024
| } | ||
|
|
||
| return ok(buyChannelData); | ||
| return ok(order); |
There was a problem hiding this comment.
The transaction is already setup correctly and the amount validated in the beginning of the transfer flow so this can be simplified to only updating the recipient address and amount.
pwltr
force-pushed
the
fix/transfer-fixes
branch
from
7b51fee to
a2e1f98
Compare
coreyphillips
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues/Tasks
Closes #2393 #2249
Type of change
Tests
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.16.-.2024-12-17.at.16.01.55.mp4
QA Notes
Because the LSP service fee estimation when calculating the max amount is slightly lower than the actual there will be a dust output leftover which is added to the onchain fee.