Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(send): update review screen #2398

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(send): update review screen #2398

merged 1 commit into from
Dec 13, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Dec 11, 2024

Description

Part of design update v53

On Send & Review screen:

  • show unified URI if applicable
  • truncate invoice URI & note
  • allow editing URI

Linked Issues/Tasks

Closes #2203

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-11.at.14.59.14.mp4

QA Notes

Make sure updating the URI works as expected.

@pwltr pwltr merged commit 3913667 into master Dec 13, 2024
7 checks passed
@pwltr pwltr deleted the fix/send-review branch December 13, 2024 17:36
@catch-21
Copy link
Contributor

Verified on v1.0.8
Works well on small iPhone8 and looks fine on larger android screen too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to tag send payment on smaller device screen
3 participants