Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show warning if user tryies to use slashpay and LDK is not ready yet #2391

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

limpbrains
Copy link
Collaborator

Description

We can probably show BottomSheet with Lightning loading indicator but that's requires adding another sheet + altering Scaner logic. I think it would be enought to just show a toast. It is quite a rare case.

Linked Issues/Tasks

closes #2377

Type of change

Bug fix

Tests

No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-12-09.at.12.28.29.mp4

QA Notes

@limpbrains limpbrains marked this pull request as ready for review December 9, 2024 16:20
@limpbrains limpbrains requested a review from pwltr December 9, 2024 16:20
Copy link
Collaborator

@pwltr pwltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@limpbrains limpbrains merged commit 196ee0a into master Dec 11, 2024
7 checks passed
@limpbrains limpbrains deleted the slow-slashpay branch December 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pay to contact can take a long time to show payment flow
2 participants