Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: force Intl polyfill #2387

Merged
merged 1 commit into from
Dec 6, 2024
Merged

perf: force Intl polyfill #2387

merged 1 commit into from
Dec 6, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Dec 6, 2024 •
edited
Loading

Description

Use -force variants for Intl polyfills. On hermes we already know it is not supported, so this skips the checks. Time to first paint is down to 2.34s from 4.4s on my Pixel 6.

Linked Issues/Tasks

#2014

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr requested a review from limpbrains December 6, 2024 10:51
@pwltr pwltr merged commit a195eb7 into master Dec 6, 2024
7 checks passed
@pwltr pwltr deleted the fix/android-startup branch December 6, 2024 11:17
@pwltr pwltr self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees

@pwltr pwltr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @limpbrains