Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(send): allow scroll on Review screen #2381

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 29, 2024

Description

Add <ScrollView /> on the ReviewAndSend screen to fix unreachable UI on smaller devices.

Linked Issues/Tasks

Closes #2203

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-11-29.at.12.49.21.mp4

@pwltr pwltr requested a review from limpbrains November 29, 2024 14:45
@pwltr pwltr merged commit 8d7c662 into master Nov 29, 2024
7 checks passed
@pwltr pwltr deleted the fix/bottom-sheet-scroll branch November 29, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to tag send payment on smaller device screen
2 participants