Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): #2368 add slider tap gesture #2369

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix(ui): #2368 add slider tap gesture #2369

merged 1 commit into from
Nov 27, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 27, 2024

Description

Adds tap gesture to the QuickPay slider.

Linked Issues/Tasks

Closes #2368

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.16.-.2024-11-27.at.16.01.32.mp4

QA Notes

Tapping on slider should also work, also has enlarged vertical hitbox.

@pwltr pwltr requested a review from limpbrains November 27, 2024 15:07
@pwltr pwltr merged commit 0e73f15 into master Nov 27, 2024
6 of 7 checks passed
@pwltr pwltr deleted the fix/slider-tap branch November 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow tapping on QuickPay threshold bar to change value
2 participants