Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add QuickPay #2357

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: add QuickPay #2357

merged 1 commit into from
Nov 25, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 22, 2024

Description

Add QuickPay: settings screen and scanner logic

Linked Issues/Tasks

Closes #2058

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.16.-.2024-11-22.at.17.45.09.mp4

QA Notes

Make sure QuickPay threshold is respected. It should only work for unified and lightning invoices with an amount.

@pwltr pwltr force-pushed the feat/quickpay branch 2 times, most recently from 43ccfcf to c4be1e2 Compare November 22, 2024 16:47
@pwltr pwltr marked this pull request as ready for review November 22, 2024 16:47
@pwltr pwltr requested a review from limpbrains as a code owner November 22, 2024 16:47
Copy link
Collaborator

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It behaves strangely when I'm trying to pay for invoice that fails

Simulator.Screen.Recording.-.iPhone.15.-.2024-11-25.at.12.33.12.mp4

src/components/Slider.tsx Outdated Show resolved Hide resolved
@pwltr
Copy link
Collaborator Author

pwltr commented Nov 25, 2024

It behaves strangely when I'm trying to pay for invoice that fails

Simulator.Screen.Recording.-.iPhone.15.-.2024-11-25.at.12.33.12.mp4

Fixed by using useFocustEffect

@pwltr pwltr requested a review from limpbrains November 25, 2024 16:26
@pwltr pwltr merged commit 8dcc70b into master Nov 25, 2024
7 checks passed
@pwltr pwltr deleted the feat/quickpay branch November 25, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: QuickPay
2 participants