Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(activity): tab indicator animation #2354

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(activity): tab indicator animation #2354

merged 1 commit into from
Nov 18, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 18, 2024

Description

The active tab indicator sometimes wasn't at the correct y position. This fixes it using layout instead of hardcoded top value.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.16.-.2024-11-18.at.15.58.04.mp4

@pwltr pwltr requested a review from limpbrains November 18, 2024 15:03
@pwltr pwltr merged commit 71877d6 into master Nov 18, 2024
7 checks passed
@pwltr pwltr deleted the fix/tab-bar branch November 18, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @limpbrains