Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warning if user tries to switch apps during LN receive #2346

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

limpbrains
Copy link
Collaborator

Description

It works better on iOS because it has inactive state, where but is not yet fully background.

Linked Issues/Tasks

#2319

Type of change

New feature

Tests

No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.16.-.2024-11-11.at.13.53.08.mp4

QA Notes

  • open receive with LN invoice shown
  • try to put app into background

@limpbrains limpbrains self-assigned this Nov 11, 2024
@limpbrains limpbrains requested a review from pwltr November 11, 2024 15:59
@limpbrains limpbrains marked this pull request as ready for review November 11, 2024 16:00
@limpbrains limpbrains force-pushed the receive-background-warning branch from 6d05a17 to bd60e4c Compare November 19, 2024 11:39
@limpbrains limpbrains merged commit ff16301 into master Nov 19, 2024
7 checks passed
@limpbrains limpbrains deleted the receive-background-warning branch November 19, 2024 16:39
@catch-21
Copy link
Contributor

catch-21 commented Nov 28, 2024

Tested on release-v1.0.7 [3b9a833]
Works well on iPhone.
Using android, it shows the message once you return to the app. This is still useful even if it is noticed after an attempted spend.

Screenrecorder-2024-11-28-16-45-41-413.1.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants