Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(send): show confetti for pending payment success #2342

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Nov 8, 2024

Description

If a payment is pending (fe. hold invoice) but still resolves while the send sheet is open, show confetti.

Linked Issues/Tasks

Closes #2248

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-11-08.at.11.31.53.mp4

@pwltr pwltr merged commit d8be953 into master Nov 8, 2024
7 checks passed
@pwltr pwltr deleted the fix/pending-payment branch November 8, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Spending Pending payment bottom sheet remains when payment succeeds
2 participants