Migrate Core project to .NET Standard 1.0 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it work things needs to be done: * Completely remove SerializationAttribute * Create custom IsInstanceOfType (API has changed) * Create own ExcludeFromCodeCoverage (tools rely more on name than concrete type with namespace)
|
Nie wiem jak budujecie Package NuGetowy (właśnie jak?) więc nie testowałem czy się poprawnie tworzy. |
kmorcinek
added a commit
to kmorcinek/synergy.contracts
that referenced
this pull request
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18
Udało się na .NET Standard 1.0 (czyli każdy klient będzie mógł z tego korzystać). Poniżej description z commita wraz z linkami dlaczego tak zrobiłem.
To make it work things needs to be done:
(tools rely more on name than concrete type with namespace) - tak zrozumiałem z dyskusji https://github.com/dotnet/corefx/issues/14488