-
Notifications
You must be signed in to change notification settings - Fork 201
Conversation
remove @rh-uxd pkg (it is archived) further alignment of patternfly dependency versions update usage of labels for integration status shuffle yarn workspace hoist configurations [cleanup] remove unnecessary hoist configs, aliasing, dependencies, comments, and types [cleanup] bump atlasmap/atlasmap version
app/ui-react/packages/atlasmap-adapter/src/DataMapperAdapter.tsx
Outdated
Show resolved
Hide resolved
I suspect the QE checks fail because this PR only bumps the UI. @igarashitm wonder, would it be easier to try and apply the updates on the Java side on this PR? Or is there an easier way to tackle this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we no longer need the bits implemented in #8561?
I sent a PR to @seanforyou23 's branch |
Thanks @igarashitm! I built the branch here locally and had a look at the "import-edit-integration" integration there on staging and indeed the AtlasMap UI doesn't load up properly there, let's see how the QE checks do once the AtlasMap backend is in sync. |
chore: Update to AtlasMap 2.3.0-M.3 for backend
Looks like we had an API change @igarashitm
Also @seanforyou23 is having a look to be sure the CSS is being applied correctly on AtlasMap, he may have some questions there. |
Ah, the base styles for atlasmap were not being imported. After adding it everything seems to have snapped right back in place.. win! If we can get the atlasmap stylesheet published to dist like the other packages it would make for a cleaner import path. In the mean time I'm just importing it from node_modules which I suppose it fine for now. Let me know if you find anything else! |
ugh right, maven classpath request has been removed - removed it and trying to build but then I hit "unused dependency" error in verifier, trying to see what's wrong. |
@seanforyou23 OK this should fix the backend build error - seanforyou23#2 |
fix: AtlasMap maven classpath request endpoint has been removed
@seanforyou23 one more chore, unused dependency in POM I couldn't find in local build - seanforyou23#3 |
chore: Remove unused dependency
@mkralik3 wonder is there an outage? Seems the PR checks are stuck. |
@gashcrumb I will try to rerun it. |
retest this please |
1 similar comment
retest this please |
We can ignore that 1 failed test because the latest Syndesis upstream contains updated AtlasMap and probably some selector was changed so UI test suite needs an update too. I will do it after verified the last prod build which contains the older AtlasMap. |
Ok thanks @mkralik3! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged, let's get this in and polish if/as needed. |
This PR aligns dependency usage among several submodules. We previously had a somewhat hacky way of importing patternfly styles, and to be honest I'm not sure I ever fully understood why that was necessary. My guess is that there were stylesheet load order issues coming from us having several submodules which all had different versions of patternfly being used. Anyway, I've managed to make all the versions aligned now and was able to get rid of all those individual stylesheet layers for a single import of
@patternfly/react-core/dist/styles/base.css
which is how it should be.@rh-uxd/integration-*
pkgs are no longer under active development, so we've ripped those bits out of @syndesis/syndesis and @syndesis/ui - we're no longer getting duplicate styles from this module.Overall things are looking pretty darn good! Please let me know if you see any issues or have any questions about these changes.
steps toward resolving ENTESB-14379 / #8707
remove
@rh-uxd/*
pkg (it is archived)remove cross console navigation
further alignment of patternfly dependency versions
update usage of labels for integration status
shuffle yarn workspace hoist configurations