Fix: IOUring timer management #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iouring module was wrongfully propagating to a non-timeout wait from a timeout submitAndWait under certain circumstances, leading to timeouts never happening. `dirtyTimers` need to be toggled even when no timers were triggered. This is because the timingwheel implementation doesn't return the exact time the next timer is to be triggered, but maxes that at 255 * tick size. Test Plan: `dub test`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iouring module was wrongfully propagating to a non-timeout wait from a timeout submitAndWait under certain circumstances, leading to timeouts never happening.
dirtyTimersneed to be toggled even when no timers were triggered. This is because the timingwheel implementation doesn't return the exact time the next timer is to be triggered, but maxes that at 255 * tick size.Test Plan:
dub test.