Add versioned dev_requirements for py 3.8 3.9 3.10 #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different version of python have different dev requirements. Previously,
dev_requirements.txt
was generated for python3.8 and assumed to work for other versions of python.That was more or less a safe assumption, except is now causing problems. Specifically, gtsam is not available on python 3.10, but we'd like to add it as a dev requirement for python 3.8 and 3.9.
symforce_requirements_test.py
cannot be run until symforce has been installed, but one might reasonably want topip install -r dev_requirements.txt
before installing symforce (to use the pinned build depencies during installation).To make this circular dependency less painful for the user, I'm adding
dev_requirements_38.txt
dev_requirements_39.txt
dev_requirements_310.txt
so that the correct dev requirements can be installed before symforce installation for any supported python version.Modified
test/symforce_requirements_test.py
to only test/update thedev_requirements_XY.txt
of the python version being used.Since the public CI is already running this test, it will guarentee that none of these files will go out of date.
Needed to amend both ci.yml and docs.yml to use the correct
dev_requirements_XY.txt
.Also needed to update the
README.md
accordingly.