Skip to content

Commit

Permalink
Merge branch '5.4' into 6.2
Browse files Browse the repository at this point in the history
* 5.4:
  [Translation][Mailer] Convert `$this` calls to static ones in data providers
  [BC Break] Make data providers for abstract test cases static
  use TestCase suffix for abstract tests in Tests directories
  Fix Request locale property doc types
  Bump absolute lowest dep to 4.4
  • Loading branch information
nicolas-grekas committed Feb 17, 2023
1 parent 0300427 commit de61859
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Tests/SmsFactorTransportFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function createFactory(): SmsFactorTransportFactory
return new SmsFactorTransportFactory();
}

public function createProvider(): iterable
public static function createProvider(): iterable
{
yield [
'sms-factor://api.smsfactor.com?sender=MyCompany&push_type=alert',
Expand All @@ -33,7 +33,7 @@ public function createProvider(): iterable
];
}

public function supportsProvider(): iterable
public static function supportsProvider(): iterable
{
yield [true, 'sms-factor://TOKEN@default?sender=MyCompany&push_type=alert'];
yield [true, 'sms-factor://TOKEN@default?sender=MyCompany&push_type=marketing'];
Expand All @@ -43,12 +43,12 @@ public function supportsProvider(): iterable
yield [false, 'somethingElse://TOKEN@default'];
}

public function incompleteDsnProvider(): iterable
public static function incompleteDsnProvider(): iterable
{
yield 'missing token' => ['sms-factor://default?sender=MyCompany&push_type=marketing'];
}

public function unsupportedSchemeProvider(): iterable
public static function unsupportedSchemeProvider(): iterable
{
yield ['somethingElse://TOKEN@default'];
}
Expand Down

0 comments on commit de61859

Please sign in to comment.