-
-
Notifications
You must be signed in to change notification settings - Fork 160
Add Panther test suite for demo scenarios and profiler integration #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
oha 😂 |
Co-authored-by: OskarStark <[email protected]>
Co-authored-by: OskarStark <[email protected]>
Co-authored-by: OskarStark <[email protected]>
|
@copilot require dbrekelmans/bdi ^1.4 and symfony/panther ^2.4 |
Co-authored-by: OskarStark <[email protected]>
|
@copilot check the failure in build https://github.com/symfony/ai/actions/runs/20892160584/job/60024910842?pr=1371 |
|
@copilot check also this ci failure: https://github.com/symfony/ai/actions/runs/20892160594/job/60024907738?pr=1371 |
Co-authored-by: OskarStark <[email protected]>
Fixed in d08e2c5. The PHPStan errors were caused by unused Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: OskarStark <[email protected]>
Fixed in 030d211. The Integration/Demo test was failing because PHPUnit was trying to parse the Panther test files even though they were excluded from the default test suite. Added conditional class definition to PantherTestCase that provides a dummy implementation when Panther is not installed, allowing the tests to be gracefully skipped. |
Plan: Panther Test Suite for Demo Scenarios & Profiler
Summary
Added comprehensive Panther-based browser integration tests for the demo application that verify all scenarios and profiler integration.
Test Coverage
DemoScenariosTest.php - Tests all 8 demo scenarios:
ProfilerIntegrationTest.php - Tests Web Profiler integration:
PANTHER_APP_ENVand skip when not in dev modeDependencies
Updated per review:
dbrekelmans/bdi: ^1.4(was ^2.0)symfony/panther: ^2.4(was ^3.0)Recent Fixes
$crawlervariables in page load testsclass_exists()checkKey Features
PantherTestCase Base Class with helper methods:
requiresOpenAiKey(): Skip test if API key not availablerequiresHuggingFaceToken(): Skip test if HF token not availablewaitForElement(): Wait for elements to appearwaitForText(): Wait for specific textSeparate Test Suite in phpunit.xml:
--testsuite=pantherEnvironment Configuration:
.env.test: Base test configuration.env.panther: Panther-specific configuration for dev mode testingError Handling:
var/error-screenshots/GitHub Actions Workflow
Created
run-demo-tests.yamlworkflow that:Documentation
PANTHER_TESTS.md: Comprehensive guide covering:
Updated demo README.md:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.