Skip to content

[Platform] Rename CachePlatform and split it as a separate package #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Guikingone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Platform] Rename CachePlatform and split it as a separate package #1339

Guikingone wants to merge 1 commit into from

Conversation

@Guikingone
Copy link
Contributor

@Guikingone Guikingone commented Jan 3, 2026 •
edited
Loading

Q A
Bug fix? yes
New feature? no
Docs? no
Issues Discussed on Slack with @marco-jouwweb
License MIT

@Guikingone Guikingone changed the title refactor(platform): fix for CachedPlatform [Platform] Fix for CachedPlatform storage Jan 3, 2026
@Guikingone Guikingone force-pushed the fix/cached_platform branch 2 times, most recently from d2b92cd to e7fa1d2 Compare January 5, 2026 13:07
@Guikingone Guikingone marked this pull request as ready for review January 5, 2026 18:31
@carsonbot carsonbot added Bug Something isn't working Platform Issues & PRs about the AI Platform component Status: Needs Review labels Jan 5, 2026
chr-hertel
chr-hertel reviewed Jan 6, 2026
View reviewed changes
@chr-hertel
Copy link
Member

chr-hertel commented Jan 6, 2026

Looking at this growing (and i guess it's necessary), and seeing failover going into a separate bridge, and that symfony/string check, i wonder if this should be a dedicated bridge as well - WDYT?

@OskarStark
Copy link
Contributor

OskarStark commented Jan 6, 2026

Yes makes sense

@Guikingone
Copy link
Contributor Author

Guikingone commented Jan 6, 2026

Make sense, what about the name? Was tempted to call it Cache 😅

@Guikingone Guikingone force-pushed the fix/cached_platform branch 4 times, most recently from b7546b3 to b0f8cf5 Compare January 6, 2026 17:10
@Guikingone Guikingone changed the title [Platform] Fix for CachedPlatform storage [Platform] Move CachedPlatform to separate package && fix for storage Jan 6, 2026
@Guikingone Guikingone changed the title [Platform] Move CachedPlatform to separate package && fix for storage [Platform] Move CachedPlatform to separate package + fix for storage Jan 6, 2026
@Guikingone Guikingone requested a review from chr-hertel January 6, 2026 17:15
OskarStark
OskarStark reviewed Jan 6, 2026
View reviewed changes
OskarStark
OskarStark reviewed Jan 6, 2026
View reviewed changes
OskarStark
OskarStark reviewed Jan 6, 2026
View reviewed changes
@Guikingone Guikingone force-pushed the fix/cached_platform branch from 9a7b665 to 722e7ad Compare January 6, 2026 19:58
@Guikingone Guikingone mentioned this pull request Jan 6, 2026
Merged
chr-hertel added a commit that referenced this pull request Jan 6, 2026
@chr-hertel
minor #1352 [Platform] Change on PlainConverter namespace (Guikingone)
61662f4 
This PR was merged into the main branch.

Discussion
----------

[Platform] Change on `PlainConverter` namespace

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        | See #1339
| License       | MIT

Commits
-------

7a5c32f ref
@Guikingone Guikingone force-pushed the fix/cached_platform branch 4 times, most recently from 99f8fa0 to d04fbd8 Compare January 8, 2026 11:01
@Guikingone Guikingone changed the title [Platform] Rename CachePlatform and move it to separate package [Platform] Rename CachePlatform and split it as a separate package Jan 12, 2026
OskarStark
OskarStark reviewed Jan 12, 2026
View reviewed changes
OskarStark
OskarStark reviewed Jan 12, 2026
View reviewed changes
@Guikingone Guikingone force-pushed the fix/cached_platform branch 2 times, most recently from b96519b to c51cd6e Compare January 12, 2026 10:01
@Guikingone Guikingone requested a review from OskarStark January 12, 2026 10:08
@Guikingone Guikingone force-pushed the fix/cached_platform branch 3 times, most recently from 6b57275 to 331c3cb Compare January 15, 2026 08:12
OskarStark
OskarStark reviewed Jan 15, 2026
View reviewed changes
OskarStark
OskarStark reviewed Jan 15, 2026
View reviewed changes
@Guikingone Guikingone requested a review from OskarStark January 15, 2026 08:53
OskarStark
OskarStark reviewed Jan 15, 2026
View reviewed changes
OskarStark
OskarStark reviewed Jan 15, 2026
View reviewed changes
@Guikingone Guikingone requested a review from OskarStark January 15, 2026 12:55
chr-hertel
chr-hertel reviewed Jan 18, 2026
View reviewed changes
@Guikingone Guikingone requested a review from chr-hertel January 18, 2026 18:30
@Guikingone Guikingone requested a review from OskarStark January 18, 2026 18:30
chr-hertel
chr-hertel reviewed Jan 18, 2026
View reviewed changes
src/platform/tests/Serializer/ResultNormalizerTest.php
* file that was distributed with this source code.
*/

namespace Symfony\AI\Platform\Tests\Serializer;
Copy link
Member

@chr-hertel chr-hertel Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be moved as well => Symfony\AI\Platform\Bridge\Cache\Tests

chr-hertel
chr-hertel requested changes Jan 18, 2026
View reviewed changes
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to src/platform/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chr-hertel chr-hertel chr-hertel requested changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees

No one assigned

Labels

Bug Something isn't working Platform Issues & PRs about the AI Platform component Status: Needs Work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Guikingone @chr-hertel @OskarStark @carsonbot