[Store] Add RecursiveCharacterTextTransformer
#1258
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asrar <[email protected]>
aszenz
commented
Dec 22, 2025
| * @param non-empty-list<string> $separators | ||
| * @return iterable<string> | ||
| */ | ||
| private static function splitText(string $text, array $separators, int $chunkSize): iterable |
Contributor
Author
There was a problem hiding this comment.
langchain seems to do this with regex, maybe that's faster and more flexible
Contributor
There was a problem hiding this comment.
What about using UnicodeString?
aszenz
changed the title
OskarStark
changed the title
RecursiveCharacterTextTransformer
OskarStark
reviewed
Dec 29, 2025
| use Symfony\AI\Store\Document\TransformerInterface; | ||
| use Symfony\Component\Uid\Uuid; | ||
|
|
||
| class RecursiveCharacterTextTransformer implements TransformerInterface |
OskarStark
reviewed
Dec 29, 2025
Comment on lines
+32
to
+35
| public function transform( | ||
| iterable $documents, | ||
| array $options = [], | ||
| ): iterable { |
Contributor
There was a problem hiding this comment.
Suggested change
| public function transform( | |
| iterable $documents, | |
| array $options = [], | |
| ): iterable { | |
| public function transform(iterable $documents, array $options = []): iterable | |
| { |
OskarStark
reviewed
Dec 29, 2025
Comment on lines
+96
to
+97
|
|
||
|
|
OskarStark
reviewed
Dec 29, 2025
| { | ||
| #[Test] | ||
| #[DataProvider('provideDocumentsContents')] | ||
| public function it_works(array $inputDocumentsText, array $options, array $expectedSplittedTexts): void |
Contributor
There was a problem hiding this comment.
Suggested change
| public function it_works(array $inputDocumentsText, array $options, array $expectedSplittedTexts): void | |
| public function ...(array $inputDocumentsText, array $options, array $expectedSplittedTexts): void |
Please use camelCase and be more descriptive
Contributor
|
Do you want to finish this PR? |
Contributor
Author
I became a bit busy this month so if anyway wants to pick this up, feel free to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not an good implementation , just exploring