Open
Conversation
for more information, see https://pre-commit.ci
rth
reviewed
Jan 16, 2026
Member
rth
left a comment
rth
left a comment
There was a problem hiding this comment.
Thanks! a few comments below and this also needs some unit tests.
|
|
||
| Args: | ||
| lat (float): latitude | ||
| lon (float): longitude |
|
|
||
| return pd.DataFrame(columns=self._data.columns) | ||
|
|
||
| def query_geocode(self, lat: float, lon: float): |
Member
There was a problem hiding this comment.
let's call it query_coordinates maybe.
Also I think it would be better to also add a top_k: int=1 param and returns a dataframe not a series, similar to how query_location works. Add the return type annotations.
| np.array([[lat, lon]]), np.array([[row["latitude"], row["longitude"]]]) | ||
| ), | ||
| axis=1, | ||
| ) |
Member
There was a problem hiding this comment.
You can build the array of coordinates _data_frame and pass it to haversine_distance directly (it should work with arrays of shape N, that would be faster.
| nearest_index = distances.idxmin() | ||
|
|
||
| # Return the nearest row | ||
| nearest_row = self._data_frame.loc[nearest_index].copy() |
Member
There was a problem hiding this comment.
Here you can argsort distances and return top_k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7
Feel free to edit as you wish