Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Upgrade frontend build stack #478

Merged

Conversation

GuySartorelli
Copy link
Collaborator

See silverstripe/silverstripe-admin#1389 for a wider discussion on most of the changes

Parent issue

@GuySartorelli GuySartorelli force-pushed the pulls/6/frontend-build-stack branch from 550db4f to 1c34418 Compare January 26, 2023 01:35
Copy link
Collaborator

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried testing, though there's a PHP error in there when I edit a workflow in the Workflows ModelAdmin

Invalid sort column "Member"."Surname"
DataList->validateSortColumn():374

It's related to making DataList->sort() no longer accepting raw sql, somewhere in the code you'll need to change a ->sort($sort) to an ->orderBy($sort)

@GuySartorelli
Copy link
Collaborator Author

Oops, yup this is something that I had fixed locally at the time but forgot to create a PR. The problem is actually in framework.
See silverstripe/silverstripe-framework#10675

Copy link
Collaborator

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried adding a new workflow step on the default workflow and I got this error

image

@GuySartorelli
Copy link
Collaborator Author

Admin needed the jquery ui fix to be merged up. I thought I had tested this one but I guess not... gave it a good run through its paces this time and seems fine. You'll want to pull the latest 2 from admin to get the merged up jqueryui changes.

Note there is a new related issue: #480

@emteknetnz emteknetnz merged commit 6f8b057 into symbiote:6 Feb 7, 2023
@emteknetnz emteknetnz deleted the pulls/6/frontend-build-stack branch February 7, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants