-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make backward content visible in input field #1198
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! Why is it limited to only working when going backward? Is it possible to apply it to moving forward as well? |
Moving forward is a bit tricky, because when you typing, the cursor is also moving forward. |
It also supports moving forward now. |
Thanks, I'll give it a thorough test later to see if it affects anything else. |
Now I've made the offset deterministic, thanks for testing as I don't know how wide it will affect. |
Hi, I tested it, and it affects the cursor position rendering for CJK characters. With the patch: screenshot-001061.mp4Previous behavior: screenshot-001063.mp4Test filename: |
Now CJK should work |
6c0a482
to
f5598eb
Compare
4eec20b
to
ed6ae00
Compare
33d04f9
to
3fdbbfe
Compare
9ddaba4
to
ef1a31a
Compare
f2e33da
to
c65bdb3
Compare
2b70f8d
to
5e48df5
Compare
43473db
to
d72f903
Compare
1394fb4
to
62ac224
Compare
Closes #1192.