Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make backward content visible in input field #1198

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Xerxes-2
Copy link
Contributor

@Xerxes-2 Xerxes-2 commented Jun 24, 2024

Closes #1192.

@sxyazi
Copy link
Owner

sxyazi commented Jun 24, 2024

Thanks for the PR!

Why is it limited to only working when going backward? Is it possible to apply it to moving forward as well?

@Xerxes-2
Copy link
Contributor Author

Xerxes-2 commented Jun 24, 2024

Thanks for the PR!

Why is it limited to only working when going backward? Is it possible to apply it to moving forward as well?

Moving forward is a bit tricky, because when you typing, the cursor is also moving forward.
As for now, implement it for moving backward is the simple choice.
Implemented

@Xerxes-2
Copy link
Contributor Author

Xerxes-2 commented Jun 26, 2024

Thanks for the PR!

Why is it limited to only working when going backward? Is it possible to apply it to moving forward as well?

It also supports moving forward now.

@sxyazi
Copy link
Owner

sxyazi commented Jun 28, 2024

Thanks, I'll give it a thorough test later to see if it affects anything else.

@Xerxes-2
Copy link
Contributor Author

Xerxes-2 commented Jun 28, 2024

Thanks, I'll give it a thorough test later to see if it affects anything else.

Now I've made the offset deterministic, thanks for testing as I don't know how wide it will affect.

@sxyazi
Copy link
Owner

sxyazi commented Jun 29, 2024

Hi, I tested it, and it affects the cursor position rendering for CJK characters.

With the patch:

screenshot-001061.mp4

Previous behavior:

screenshot-001063.mp4

Test filename: ddfa36dc-361a-11ef-9454-鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅呃呃呃呃鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅0242ac120002-e3e8ed04-361a-11ef-9454-0242ac120002

@Xerxes-2
Copy link
Contributor Author

Hi, I tested it, and it affects the cursor position rendering for CJK characters.

With the patch:

screenshot-001061.mp4
Previous behavior:

screenshot-001063.mp4
Test filename: ddfa36dc-361a-11ef-9454-鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅呃呃呃呃鹅鹅鹅鹅鹅鹅鹅鹅鹅鹅0242ac120002-e3e8ed04-361a-11ef-9454-0242ac120002

Now CJK should work

@sxyazi sxyazi added this to the v0.3.1 milestone Jul 5, 2024
@sxyazi sxyazi force-pushed the main branch 5 times, most recently from 6c0a482 to f5598eb Compare July 13, 2024 06:22
@sxyazi sxyazi force-pushed the main branch 2 times, most recently from 4eec20b to ed6ae00 Compare July 16, 2024 10:50
@sxyazi sxyazi force-pushed the main branch 6 times, most recently from 33d04f9 to 3fdbbfe Compare August 2, 2024 09:43
@sxyazi sxyazi force-pushed the main branch 4 times, most recently from 9ddaba4 to ef1a31a Compare October 26, 2024 09:09
@sxyazi sxyazi force-pushed the main branch 12 times, most recently from f2e33da to c65bdb3 Compare November 14, 2024 05:08
@sxyazi sxyazi force-pushed the main branch 10 times, most recently from 2b70f8d to 5e48df5 Compare November 26, 2024 09:11
@sxyazi sxyazi force-pushed the main branch 2 times, most recently from 43473db to d72f903 Compare November 30, 2024 13:26
@sxyazi sxyazi force-pushed the main branch 2 times, most recently from 1394fb4 to 62ac224 Compare December 9, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Move rename input box view adaptively
2 participants