-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: playwright tests #64
Conversation
Includes setup and teardown scripts for copying swup and plugin js files to `fixtures/dist`
TIL caching playwright isn't necessarily speeding up actions. Without cache: 2m 20s |
@daun do you understand what's happening here? https://github.com/swup/fragment-plugin/actions/runs/6860973311/job/18655736640?pr=64#step:8:10
If I understand the config correctly, it should spit out the reporter: process.env.CI
? [['dot'], ['github'], ['json', { outputFile: '../../report.json' }]]
: [['list'], ['html', { outputFolder: '../reports/html', open: 'on-failure' }]], Although swup's playwright config doesn't even report JSON at all when in CI: https://github.com/swup/swup/blob/1cd87ea335b95b9b8caee602634974f5011d2cc7/tests/config/playwright.config.ts#L32-L40 |
It's not THAT important I'd say, I could totally live without the reporter in the PR tbh :) |
@hirasso It's currently |
Haha true 😆 so many trees 🌲🌳🌴🏝️ |
OMG it's working! 🤯🥳 ...ready for review 🤪 |
I guess the playwright shield status will appear when this is merged. |
I decided to use "vitest" and "playwright" instead of "unit" and "e2e" since the vitest tests aren't all real unit tests. The line is blurry. |
Makes sense! The reason I've used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🥯
Description
Adds basic e2e test coverage to the plugin.
Checks
master
branchnpm run lint
)npm run test
)