New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update additional body attributes #39

Merged

daun merged 1 commit into master from feat/attributes

Oct 19, 2024

Member

daun commented Oct 18, 2024

Description

Allow updating other attributes on the body element
Filterable by string or regex: ['lang', 'dir', /^data-/]
I would go with an empty array by default — lang and dir should be defined on the html element and we can also avoid a breaking change that way. For the head plugin, we should think about making lang and dir the default and making it a major release, though

Checks

The PR is submitted to the master branch
The code was linted before pushing (npm run lint)
All tests are passing (npm run test)
New or updated tests are included
The documentation was updated as required

Additional information

Closes #36


          Add ability to update additional body attributes

c476cb5

daun requested a review from a team

October 18, 2024 20:57

hirasso approved these changes

View reviewed changes

Member

hirasso left a comment

Beautiful! ✨

daun merged commit ce914bc into master

1 check passed

daun deleted the feat/attributes branch

October 19, 2024 09:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet