Adds support to AWS MSK IAM auth method #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einacio
reviewed
Dec 9, 2022
examples/consumer_msk.php
Outdated
| $config->setInterval(0.1); | ||
| $config->setSasl([ | ||
| "type"=> AwsMskIamSasl::class, | ||
| "host"=>"localhost", |
There was a problem hiding this comment.
this is not used in the current version and is confusing
There was a problem hiding this comment.
@einacio are you suggesting removing the consumer_msk file?
There was a problem hiding this comment.
no, i refer to the host config. the code reads it from the socket, not from the sasl config
Co-authored-by: einacio <[email protected]>
Co-authored-by: einacio <[email protected]>
Co-authored-by: einacio <[email protected]>
Co-authored-by: einacio <[email protected]>
einacio
approved these changes
Jan 10, 2023
|
@valmoz hi, I wonder if there is no need to additionally configure the credentials (key and secret) of aws? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #71