chore: refactor ssh pool implementation #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmoysrt
changed the title
- because ssh check function already done the job
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2024
* chore: modularize the MonitorServerStatus function * feat: no need to delete ssh client if server is already offline - because ssh check function already done the job * feat: reduce delete ssh client call * feat: optimize the server status fixing algo * feat: pre-validation for ssh has been added * chore: reduce complexity (cherry picked from commit 38e6664)
tanmoysrt
added a commit
that referenced
this pull request
Sep 28, 2024
* chore: modularize the MonitorServerStatus function * feat: no need to delete ssh client if server is already offline - because ssh check function already done the job * feat: reduce delete ssh client call * feat: optimize the server status fixing algo * feat: pre-validation for ssh has been added * chore: reduce complexity (cherry picked from commit 38e6664) Co-authored-by: Tanmoy Sarkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.