Setup Windows GH actions job #1195
Draft
+340
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
force-pushed
the
win-gh-actions
branch
2 times, most recently
from
cf61bf1
to
a64cba3
Compare
plemarquand
reviewed
Nov 4, 2024
award999
force-pushed
the
win-gh-actions
branch
from
acfdd24
to
7014f83
Compare
|
@swift-ci Please test |
award999
force-pushed
the
win-gh-actions
branch
8 times, most recently
from
6dc7960
to
ad86a3a
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
award999
force-pushed
the
win-gh-actions
branch
8 times, most recently
from
1146056
to
8878469
Compare
plemarquand
force-pushed
the
win-gh-actions
branch
6 times, most recently
from
31971f9
to
2077b85
Compare
plemarquand
force-pushed
the
win-gh-actions
branch
2 times, most recently
from
7480355
to
7ffad88
Compare
We cannot use the existing windows job setup because it launches a docker container which we cannot open a VS Code window in to run the tests as no tool like Xvfb exists for Windows Fix up some tests that fail on windows (mostly related to path separator mismatches)
Take inspiration from the Swift Dockerfiles
(copied file for now for testing)
- Added comments to make the intent more explicit
michael-weng
force-pushed
the
win-gh-actions
branch
from
7ffad88
to
05bc130
Compare
These tests rely on the workspace-state.json being present in the .build folder, however on fresh checkouts this file has not been created before the tests run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use the existing windows job setup because it launches a docker container which we cannot open a VS Code window in to run the tests as no tool like Xvfb exists for Windows
Fix up some tests that fail on windows (mostly related to path separator mismatches)